17.5 Review Checklist [Dido Solutions, Inc Wiki]

This page is read only. You can view the source, but not change it. Ask your administrator if you think this is wrong.
====== 17.5 Review Checklist ======

[[fxdemo:05-part:start | Go To Top ]]

[[fxdemo:05-part:17-git-and-review-workflow:start | Return to Git and Review Workflow ]]

Reviewers should inspect each change against the Phase 0 Baseline. Review should not focus only on whether the code runs. It should also check traceability, reproducibility, naming, documentation, Configuration, discipline in generated Artifacts, logging, exception handling, and Evidence.

A reviewer should check:

  - The change has a clear purpose.
  - The change belongs in the Phase 0 Baseline.
  - The changed Artifacts live in the correct Repository locations.
  - Names follow the conventions defined in Section 7.
  - Handwritten and generated Artifacts remain separated.
  - IDL changes follow the rules in Section 9.
  - Node changes follow the pattern in Section 10.
  - Control Plane changes follow Section 11.
  - Data Plane changes follow Section 12.
  - Script changes follow Section 13.
  - Container changes follow Section 14.
  - Logging and observability changes follow Section 15.
  - Exception handling changes follow Section 16.
  - Tooling changes align with the applicable checklist instance defined in Section 6.
  - Tests or validation Evidence support the change.
  - Documentation changed when the implementation changed.
  - No local, temporary, personal, or machine-specific Artifacts entered the Baseline.

Reviewers should check spelling, grammar, terminology, and active-voice guidance against Section 7.11 when reviewing documentation, comments, file headers, script help text, Configuration descriptions, generated documentation templates, catalogue entries, and acceptance Evidence.

----

<WRAP centeralign>

© 2026 Dido Solutions, Inc. and Jackrabbit Consulting, Inc.

</WRAP>